Skip to content

Fix config_root_logger in non_web context #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Fix config_root_logger in non_web context #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions json_logging/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,15 @@ def config_root_logger():
if ENABLE_JSON_LOGGING:
ENABLE_JSON_LOGGING_DEBUG and _logger.debug("Update root logger to using JSONLogFormatter")
if len(logging.root.handlers) > 0:
if _current_framework is not None or _current_framework != '-':
util.update_formatter_for_loggers([logging.root], JSONLogWebFormatter)
else:
if _current_framework is None or _current_framework == '-':
util.update_formatter_for_loggers([logging.root], JSONLogFormatter)
# remove all handlers for request logging
request_logger = _current_framework['app_request_instrumentation_configurator']().get_request_logger()
if request_logger:
for handler in request_logger.handlers:
request_logger.removeHandler(handler)
else:
util.update_formatter_for_loggers([logging.root], JSONLogWebFormatter)
# remove all handlers for request logging
request_logger = _current_framework['app_request_instrumentation_configurator']().get_request_logger()
if request_logger:
for handler in request_logger.handlers:
request_logger.removeHandler(handler)
else:
_logger.error(
"No logging handlers found for root logger. Please made sure that you call this after you called "
Expand Down