tests: fix imports and test collection under some environments #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While packaging json-logging for NixOS, I've come across two issues with tests. Since neither are specific to NixOS (though they may be an artifact of how the build environment is set up), I felt it'd be better to try to stream the fixes up. - While testing, the import test for Quart finds not the 'quart' package, but tests/smoketests/quart. It's been a while since I worked on this, but it seems to happen because pytest prepends the test module directory to sys.path by default [1]. To make it work with a default pytest invocation, we can simply try to import something only the real quart package provides. - If no smoketest backends are specified, it will try to find tests in a __pycache__ directory [2] if it exists. [1]: https://docs.pytest.org/en/stable/pythonpath.html [2]: https://www.python.org/dev/peps/pep-3147/
|
@AluisioASG looks good. Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While packaging json-logging for NixOS, I've come across two issues with tests. Since neither are specific to NixOS (though they may be an artifact of how the build environment is set up), I felt it'd be better to try to stream the fixes up.
tests/smoketests/quart. It's been a while since I worked on this, but it seems to happen because pytest prepends the test module directory tosys.pathby default. To make it work with a default pytest invocation, we can simply try to import something only the real quart package provides.__pycache__directory if it exists.