Check if ok when casting Scan src to string #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! In what case would this happen? Can we add a test for it? |
|
I'm using this library here: https://github.com/jinzhu/copier and it will try to set fields differently if the object is a sql.Scanner. Proper error response appears important. https://github.com/jinzhu/copier/blob/master/copier.go#L625 Will add a test! |
|
Added test to cover new error case! |
bojanz
reviewed
Feb 18, 2024
| input := src.(string) | ||
| input, ok := src.(string) | ||
| if !ok { | ||
| return fmt.Errorf("invalid src: %v", src) |
There was a problem hiding this comment.
This error does not tell us why the value is invalid.
What if we did this instead:
return fmt.Errorf("value is not a string: %v", src)
|
@theFong |
|
Tweaked and committed in cf9e73a. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.