-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0.5, added support for ipywidgets>=8.0.0 #169
Conversation
Thanks for looking at this. It looks good, but has to be rebased unfortunately. |
@philippjfr Well, technically speaking it should be trivial to rebase as it is just one bump in the dependencies: "dependencies": {
- "@jupyter-widgets/base": "^3 || ^4.0.0",
+ "@jupyter-widgets/base": "^6", Is the current main branch ready for release? I've written an article about bokeh but I can't publish it because |
@mattpap There's a few people asking for a release now. Any chance we could make this change and then release? |
@philippjfr I've rebased against main. Now it says "Can't find module core/serialization". But I see the same message on main without my changes, too. Do you know how to deal with it? |
@philippjfr @mattpap maybe it is possible to release 3.0.5a alpha version without rebasing? And then gradually complete the serialization improvements? Because as of today jupyter_bokeh is not working at all (e.g. examples fail on fresh install of python + |
This is because |
Would be nice if we could release a fix here before bokeh 3.0 though. |
Sure. I will create a release branch off an earlier commit, merge and release, and then merge back to |
867d9ff
to
53d67d9
Compare
I rebased this and updated lock files. @axil, make sure you use npm 8+, so that lock file version is not downgraded. Looks like everything works with bokeh 2.4. |
53d67d9
to
e3f44a7
Compare
* v3.0.5, added support for ipywidgets>=8.0.0 * Update nodejs in CI Co-authored-by: Lev Maximov <lev.maximov@gmail.com> Co-authored-by: Mateusz Paprocki <mattpap@gmail.com>
* v3.0.5, added support for ipywidgets>=8.0.0 (#169) * v3.0.5, added support for ipywidgets>=8.0.0 * Update nodejs in CI Co-authored-by: Lev Maximov <lev.maximov@gmail.com> Co-authored-by: Mateusz Paprocki <mattpap@gmail.com> * Update yarn.lock * npm audit fix * Upgrade webpack and webpack-cli * Migrate the build to webpack 5 * Add index.js.LICENSE.txt * Update and unify dependencies * Update yarn.lock * Bump version to 3.0.6 * Upgrade actions and nodejs in CI * Adjust version spec scheme * Upgrade jupyter-packaging * Add types to jupyter_bokeh/widgets.py * Remove unused imports * Rename trigger_{json_->}event() * Update event handling to Bokeh 3.0 * Update .gitignore --------- Co-authored-by: Lev Maximov <axil.github@gmail.com> Co-authored-by: Lev Maximov <lev.maximov@gmail.com>
Built upon v3.0.4. Fixes #168