Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JupyterLab 2.0.0 #90

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Support JupyterLab 2.0.0 #90

merged 2 commits into from
Mar 4, 2020

Conversation

consideRatio
Copy link

@consideRatio consideRatio commented Mar 4, 2020

JupyterLab 2.0.0 is out, and this extension have conflicting dependencies with its core packages. Fixes #88.

Conflicting Dependencies:
JupyterLab                        Extension      Package
>=2.0.0 <2.1.0                    >=1.1.3 <2.0.0 @jupyterlab/application
>=2.0.0 <2.1.0                    >=1.1.3 <2.0.0 @jupyterlab/apputils
>=2.0.0 <2.1.0                    >=1.1.3 <2.0.0 @jupyterlab/notebook
>=2.0.0 <2.1.0                    >=1.4.0 <2.0.0 @jupyterlab/rendermime-interfaces
>=5.0.0 <5.1.0                    >=4.1.1 <5.0.0 @jupyterlab/services

Implementation notes

There was some manual changes needed in the code due to the following part in the JupyterLab migration guide: https://jupyterlab.readthedocs.io/en/stable/developer/extension_migration.html#using-session-and-sessioncontext-to-manage-kernel-sessions

I did my best to ensure I didn't get install / build errors, and made a guess on how to fix it. I have not tested this code in a JupyterLab UI yet.

References

@mattpap
Copy link
Contributor

mattpap commented Mar 4, 2020

$ python -m jupyterlab.selenium_check /home/travis/miniconda/bin/python: No module named jupyterlab.selenium_check The command "python -m jupyterlab.selenium_check" exited with 1.

If selenium_check was removed, then we will have to remove this part of the build.

@consideRatio
Copy link
Author

It was renamed, ill update for that when im at my computer! (on mobile now)

jupyterlab/jupyterlab#4872

@@ -1,6 +1,5 @@
language: generic
sudo: false
dist: trusty
dist: bionic
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusty is 14.04 (6 year old LTS)
Xenial is 16.04 (4 year old LTS)
Bionic is 18.04 (2 year old LTS --- seems most reasonable to use)

sudo: false is a setting that is now deprecated and does nothing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to eventually migrate this repo to github actions to unify with bokeh.

@@ -15,7 +14,7 @@ install:
- conda config --add channels bokeh
- conda config --add channels conda-forge
- conda info -a
- conda install conda-build nodejs selenium jupyterlab notebook geckodriver firefox
- conda install conda-build nodejs jupyterlab notebook
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't need selenium now when we are using the browser_check script instead of the selenium_check script, and I think geckodriver / firefox is meant for selenium.

@consideRatio
Copy link
Author

Okay! I think I'm happy with the PR as it is given what I know and understand currently.

@mattpap
Copy link
Contributor

mattpap commented Mar 4, 2020

@consideRatio, thanks for fixing this.

@mattpap mattpap merged commit 2348f19 into bokeh:master Mar 4, 2020
@codypiersall
Copy link

Thanks a bunch @consideRatio, just confirmed that it works for me!

@consideRatio
Copy link
Author

@mattpap my attribution for this contribution was erased from the git history through the way this PR was squashed and merged =/

@philippjfr
Copy link
Contributor

Very odd, never seen a squash merge do that before.

@mattpap
Copy link
Contributor

mattpap commented Mar 5, 2020

@consideRatio, it's unfortunate and must be a bug in GitHub. Squash and merge is supposed to preserve the original author and at most should have added me as a co-author. I checked a few recently merged PRs and it seems it's an isolated event.

@bryevdv
Copy link
Member

bryevdv commented Mar 5, 2020

Looks like a recent (bad) intentional change at GH:

https://twitter.com/andyhayden1/status/1235593402709716992?s=20

@bryevdv
Copy link
Member

bryevdv commented Mar 5, 2020

I poked Nat Friedman on twitter and a "fix should be deployed today" :D

@consideRatio We very much appreciate your contribution, I know it's a cliche to say that the reward for good work is more work, but please let us know if we we can help you find another good PR for you to submit that will properly credit you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension doesn't install on jupyterlab 2.0.0
5 participants