-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JupyterLab 2.0.0 #90
Conversation
If |
It was renamed, ill update for that when im at my computer! (on mobile now) |
@@ -1,6 +1,5 @@ | |||
language: generic | |||
sudo: false | |||
dist: trusty | |||
dist: bionic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trusty is 14.04 (6 year old LTS)
Xenial is 16.04 (4 year old LTS)
Bionic is 18.04 (2 year old LTS --- seems most reasonable to use)
sudo: false
is a setting that is now deprecated and does nothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to eventually migrate this repo to github actions to unify with bokeh.
@@ -15,7 +14,7 @@ install: | |||
- conda config --add channels bokeh | |||
- conda config --add channels conda-forge | |||
- conda info -a | |||
- conda install conda-build nodejs selenium jupyterlab notebook geckodriver firefox | |||
- conda install conda-build nodejs jupyterlab notebook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't need selenium now when we are using the browser_check script instead of the selenium_check script, and I think geckodriver / firefox is meant for selenium.
Okay! I think I'm happy with the PR as it is given what I know and understand currently. |
@consideRatio, thanks for fixing this. |
Thanks a bunch @consideRatio, just confirmed that it works for me! |
@mattpap my attribution for this contribution was erased from the git history through the way this PR was squashed and merged =/ |
Very odd, never seen a squash merge do that before. |
@consideRatio, it's unfortunate and must be a bug in GitHub. Squash and merge is supposed to preserve the original author and at most should have added me as a co-author. I checked a few recently merged PRs and it seems it's an isolated event. |
Looks like a recent (bad) intentional change at GH: https://twitter.com/andyhayden1/status/1235593402709716992?s=20 |
I poked Nat Friedman on twitter and a "fix should be deployed today" :D @consideRatio We very much appreciate your contribution, I know it's a cliche to say that the reward for good work is more work, but please let us know if we we can help you find another good PR for you to submit that will properly credit you. |
JupyterLab 2.0.0 is out, and this extension have conflicting dependencies with its core packages. Fixes #88.
Implementation notes
There was some manual changes needed in the code due to the following part in the JupyterLab migration guide: https://jupyterlab.readthedocs.io/en/stable/developer/extension_migration.html#using-session-and-sessioncontext-to-manage-kernel-sessions
I did my best to ensure I didn't get install / build errors, and made a guess on how to fix it. I have not tested this code in a JupyterLab UI yet.
References