Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Guard #100

Closed
tfausak opened this issue Apr 26, 2016 · 4 comments · Fixed by #101
Closed

Remove Guard #100

tfausak opened this issue Apr 26, 2016 · 4 comments · Fixed by #101
Assignees

Comments

@tfausak
Copy link
Collaborator

tfausak commented Apr 26, 2016

I don't want to bother dealing with Guard after guard/listen#371.

@tfausak tfausak self-assigned this Apr 26, 2016
tfausak added a commit that referenced this issue Apr 26, 2016
This fixes #100.
@e2
Copy link

e2 commented Apr 26, 2016

I don't want to bother dealing with Ruby < 2.2. Neither does the Ruby core team....

@tfausak tfausak mentioned this issue Apr 26, 2016
@tfausak
Copy link
Collaborator Author

tfausak commented Apr 26, 2016

I don't blame you. Dropping support for a version of Ruby is a breaking change. That is a change that should be made as part of a major version change.

tfausak added a commit that referenced this issue Apr 26, 2016
@e2
Copy link

e2 commented Apr 26, 2016

@tfausak - it wasn't about "dropping support". Support was already officially dropped - it was a bug that the dependency wasn't updated.

Also, according to SemVer, what I did was fine.

@e2
Copy link

e2 commented Apr 26, 2016

Just FWIW: The current release candidate for Bundler resolves this: on 1.9.3 even, it correctly uses a version of Listen installable with Ruby 1.9.3.

All you'd need to do is put gem install bundler --pre in your Travis config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants