fix: check if component was initially rendered before removing children, IE runs twice on background component and empties the rendered HTML

Daniel Morse · Daniel Morse · commit 4006913d631d · 2019-02-20T15:58:27.000-05:00
diff --git a/packages/components/bolt-image/src/image.js b/packages/components/bolt-image/src/image.js
@@ -66,9 +66,12 @@ class BoltImage extends withLitHtml() {
   }
 
   connecting() {
-    super.connecting && super.connecting();
-    while (this.firstChild) {
-      this.removeChild(this.firstChild);
+    // IE fires this twice, only let it remove children once
+    if (!this._wasInitiallyRendered) {
+      super.connecting && super.connecting();
+      while (this.firstChild) {
+        this.removeChild(this.firstChild);
+      }
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -66,9 +66,12 @@ class BoltImage extends withLitHtml() {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`connecting() {`
`69`		`- super.connecting && super.connecting();`
`70`		`- while (this.firstChild) {`
`71`		`- this.removeChild(this.firstChild);`
	`69`	`+ // IE fires this twice, only let it remove children once`
	`70`	`+ if (!this._wasInitiallyRendered) {`
	`71`	`+ super.connecting && super.connecting();`
	`72`	`+ while (this.firstChild) {`
	`73`	`+ this.removeChild(this.firstChild);`
	`74`	`+ }`
`72`	`75`	`}`
`73`	`76`	`}`
`74`	`77`