fix: removing auth-ed attempt at image loading

Author: EvanLovely

scripts/report-nightwatch-results.js

@@ -15,22 +15,6 @@ const auth = Buffer.from(`${SAUCE_USERNAME}:${SAUCE_ACCESS_KEY}`).toString(
   'base64',
 );
 
-/**
- * @param {string} url
- * @return {Promise<boolean>}
- */
-async function isRemoteAssetOk(url) {
-  try {
-    const { ok, status, headers } = await fetch(url);
-    const { 'Content-Length': contentLength } = headers;
-    console.log(`isRemoteAssetOk ${url}`, { ok, status, contentLength });
-    return ok;
-  } catch (err) {
-    console.error(`Error on isRemoteAssetOk for ${url}`, err);
-    return false;
-  }
-}
-
 async function collectSauceLabResults(build) {
   try {
     const buildJobs = await fetch(
@@ -60,7 +44,7 @@ async function collectSauceLabResults(build) {
     const tests = await Promise.all(
       buildJobs.map(async buildJob => {
         // just the file names, not absolute paths
-        const assetBaseUrl = `https://${SAUCE_USERNAME}:${SAUCE_ACCESS_KEY}@assets.saucelabs.com/jobs/${buildJob.id}`;
+        const assetBaseUrl = `https://assets.saucelabs.com/jobs/${buildJob.id}`;
         /** @type {{ 'sauce-log': string, 'video': string, 'selenium-log': string, screenshots: string[], 'video.mp4': string  }} */
         const assets = await fetch(
           // https://wiki.saucelabs.com/display/DOCS/Job+Methods
@@ -104,17 +88,6 @@ async function collectSauceLabResults(build) {
               }
             });
             return theAssets;
-          })
-          .then(async allAssets => {
-            return allAssets;
-            // not filtering them yet, just checking; perhaps requesting them will make them work for GitHub
-            const validScreenshots = await Promise.all(
-              allAssets.screenshots.map(async s => ({
-                ...s,
-                ok: await isRemoteAssetOk(s.url),
-              })),
-            );
-            return validScreenshots;
           });
 
         return {