Added permission setting and added missing translations #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @VincentdeWit94, Thanks! I've been out of town for a few days, so i haven't had the time to review this one yet. I'll get to it soon. 👍 |
|
Hi @VincentdeWit94, Could we make it so that the permission is a setting in the extension's config? Otherwise, the majority of people won't set it, and it'll generate a flood of lines in the log. As it happens, I bumped into that myself, the other day: bolt/bolt#7487 Like is done here, for example: https://github.com/bacbos/bolt-menu-editor/blob/master/config/config.yml.dist#L45-L47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
This PR allow's users to show and hide the Google Analytics plugin in the menu bar based on the permissions. I've also added a Dutch translation file for the Dutch Bolt users.
Thanks!