Making Contenttypes more configurable #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Seriously though, looks good at first glance.. Also, you've made the discussion in #1420 moot, because we now can tell people to just make an extension for that. ;-) |
|
ha. Purely selfish.. I need to make an extension for that. |
bobdenotter
added a commit
that referenced
this pull request
Aug 24, 2014
Making Contenttypes more configurable
|
Ross, that's great! Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we're not supposed to be adding features, but it was proving extremely complicated to make an extension that provided a new field type, and I can imagine that this will be quite a popular need for extensions.
So this makes fields on $app['config'] a manager object that can accept the adding of new fields. It also initialises the defaults and then allows the twig template to query available fields before rendering.