Fix adjustSidebarHeight so it's longer than content for admin menus #6145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No worries! Thank you for the additional fix! 👍 |
bobdenotter
approved these changes
Dec 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remember that fix I submitted for the secondary (black) menu on the left last week? I found a small issue with it.
It works great as long as the content is longer than the menu, but when the reverse is true, as it is on some of the admin menus, I saw menu items that weren't in the black anymore. I hardly ever use those menus anymore, which is why I forgot to check them.
This small adjustment to the original change fixes that, and hopefully it's perfect now.
Sorry for the extra churn!