Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis eslint prettier #128

Merged
merged 4 commits into from
Nov 17, 2018
Merged

Conversation

Ichag
Copy link
Contributor

@Ichag Ichag commented Nov 16, 2018

This PR configures eslint + prettier to lint js files.
To run it use npm run lint and for auto-fixing npm run lint-fix

@Ichag
Copy link
Contributor Author

Ichag commented Nov 16, 2018

prettier has a strong opinion about styles, it could be that is clashes with your opinion about how the code should look:

By far the biggest reason for adopting Prettier is to stop all the on-going debates over styles. It is generally accepted that having a common style guide is valuable for a project and team but getting there is a very painful and unrewarding process. People get very emotional around particular ways of writing code and nobody likes spending time writing and receiving nits.

https://prettier.io/docs/en/why-prettier.html

This was referenced Nov 16, 2018
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #113 👍

Personally, I'm fine with most conventions, as long as we pick one. Except Yoda conditions. ;-)

@bobdenotter bobdenotter merged commit f11df45 into bolt:master Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants