fix: Remove redundant button tag logic and dependency on deprecated schema

Author: remydenton

packages/components/bolt-button/src/button.twig

@@ -25,14 +25,18 @@
   {% set border_radius = "full" %}
 {% endif %}
 
+{# DEPRECATED. Use the `type` property for a reset or submit button.  Tag is determined automatically based on whether you pass a url. #}
+{% if tag in ["reset", "submit"] %}
+  {% set type = type|default(tag) %}
+{% endif %}
+
 {# Set up checks to validate that the component's prop values are allowed, based on the component's schema #}
 {% set size_options = schema.properties.size.enum %}
 {% set style_options = schema.properties.style.enum %}
 {% set width_options = schema.properties.width.enum %}
 {% set border_radius_options = schema.properties.border_radius.enum %}
 {% set align_options = schema.properties.align.enum %}
 {% set transform_options = schema.properties.transform.enum %}
-{% set tag_options = schema.properties.tag.enum %}
 {% set icon_positions = schema.properties.icon.properties.position.enum %}
 {% set iconOnly_options = schema.properties.iconOnly.enum %}
 
@@ -43,13 +47,9 @@
 {% set border_radius = border_radius in border_radius_options ? border_radius : schema.properties.border_radius.default %}
 {% set align = align in align_options ? align : schema.properties.align.default %}
 {% set transform = transform in transform_options ? transform : schema.properties.transform.default %}
-{% set tag = tag in tag_options ? tag : schema.properties.tag.default %}
 {% set iconOnly = iconOnly is sameas(true) or iconOnly is sameas(false) ? iconOnly : scheuma.properties.iconOnly.default %}
 
-{% if tag == "submit" or type == "submit" %}
-  {% set tag = "button" %}
-  {% set inner_attributes = inner_attributes.setAttribute("type", "submit") %}
-{% elseif tag == "link" or tag == "a" or url != null %}
+{% if url != null %}
   {% set tag = "a" %}
   {% if disabled %}
     {% set inner_attributes = inner_attributes.setAttribute("aria-disabled", "true") %}
@@ -61,14 +61,10 @@
   {% if attributes.target %}
     {% set inner_attributes = inner_attributes.setAttribute("target", attributes.target) %}
   {% endif %}
-{% elseif tag == "reset" or type == "reset" %}
+{% else %}
   {% set tag = "button" %}
-  {% set inner_attributes = inner_attributes.setAttribute("type", "reset") %}
-{% endif %}
-
-{# shorthand for manually setting HTML attribute `type` such as submit or reset #}
-{% if type %}
-  {% set inner_attributes = inner_attributes.setAttribute("type", type) %}
+  {% set type = type in type_options ? type : "button" %}
+  {% set inner_attributes = inner_attributes.setAttribute("type", type ) %}
 {% endif %}
 
 {# Array of classes based on the defined + default props #}