-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BDS-1573 action element schema #1789
Conversation
…BDS-1573-action-element-schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@remydenton nicely done 👍
I have one suggestion, to move url
and target
props higher up in the Link schema table, since these are some of the most commonly used props.
I pushed a branch with the change if you want to take a look or pull it in directly. See commit.
Do these edits make sense to you?
@remydenton have we confirmed what happens with the global data store if more than one schema gets exported in that |
Thanks @danielamorse, I think that's a great addition. I'll use your updates for link and make similar ones for button. @sghoweri, I've got questions about the global data store, I'll follow up on Slack. |
@remydenton Ask away! |
@danielamorse, I realized once I started that changing the order isn't really as appropriate for button since @sghoweri, I've confirmed that you can access the schemas from the element package like this: If more schemas that get added to bolt element in the future, you can just change the last part of that expression to reference the one you want. |
PR was released with v2.21.0 |
Jira
http://vjira2:8080/browse/BDS-1573
Summary
Add schema for BoltActionElement
Details
How to test
href
andurl
)disabled
prop (follow up ticket in http://vjira2:8080/browse/BDS-2072)