-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visual regression test to Blockquote to check that quote styles render correctly #1796
Conversation
…ectly if initially rendered via Twig
Note: only one reviewer should be needed here, whoever can get to this first 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamszalapski yeah I'm trying out an update that allows for up to 20 pixels to be different which, for what it's worth, is just barely the # pixel difference if one of the two sets of double quotes aren't showing up. |
OK - with quite a bit of trial and error, I think I have a VRT solution for Blockquote that should more consistently catch rendering issues (ex. missing Blockquote quotes) on MacOS and on Linux: https://github.com/boltdesignsystem/bolt/pull/1796/files#diff-372cba9a19220ba9e14566ff8b83f1b8R471 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Tested locally and it passes. It fails when I cause the quotes to disappear.
PR was released with v2.21.0 |
Jira
Follow-up to http://vjira2:8080/browse/BDS-2074
Summary
Adds a new Jest visual regression test to Blockquote that checks that the web component's quotes show up correctly when initially rendered via Twig.
FWIW, I already tested to confirm that this test should be sensitive enough to catch quotes being removed or added... for example, missing just one of the two double quotes is about a 25 to 27 pixel difference:
How to test
Confirm CI tests pass.