Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/academy blueprint updates #1798

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Conversation

danielamorse
Copy link
Collaborator

@danielamorse danielamorse commented Mar 26, 2020

Jira

http://vjira2:8080/browse/BDS-2078

Summary

I'm using Blueprints to debug UI issues on Academy. Since I'm already testing these changes in the Bolt repo, might as well push these changes back to Bolt.

Details

These are very minor changes, should not affect any code outside of Blueprints.

  • Remove reference to deleted icon
  • Fix wrapping module titles
  • Add indigo option to icon banner

How to test

  • Review code and approve if changes look fine.
    • The issues these changes address are QA'd on the Academy board so no need to test here.

@danielamorse danielamorse added this to the v2.21.0 milestone Mar 26, 2020
Copy link
Contributor

@sghoweri sghoweri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all seem super minor + straight forward.

+1 for syncing these downstream changes back into Bolt! 💯

@sghoweri sghoweri merged commit f98f56e into master Mar 26, 2020
@sghoweri
Copy link
Contributor

sghoweri commented Apr 8, 2020

PR was released with v2.21.0

@danielamorse danielamorse deleted the feature/academy-blueprint-updates branch June 8, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants