Fix List wrapping bug #1806
Merged
Fix List wrapping bug #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sghoweri
reviewed
Apr 2, 2020
| &.c-bolt-list--display-flex { | ||
| width: calc(100% + #{bolt-spacing($spacing-value-name)}); // Width must be defined in order for the list to dislay correctly in Firefox. | ||
| } | ||
| @-moz-document url-prefix('') { |
There was a problem hiding this comment.
Wait, what? Link to docs and/or comment about this please.
There was a problem hiding this comment.
Agree. Let's throw a comment in there. I've been using that, it's quite handy.
There was a problem hiding this comment.
There was a problem hiding this comment.
@sghoweri added a comment, see commit.
mikemai2awesome
approved these changes
Apr 2, 2020
sghoweri
approved these changes
Apr 8, 2020
|
PR was released with v2.21.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
http://vjira2:8080/browse/BDS-2087
Summary
Fixes Safari sub-pixel rendering bug.
Details
Setting a width on List was required to fix a FF-only bug, but it turns out it causes a different bug in Safari. To fix Safari, simply scope the
widthrule to FF-only.Supercedes #1805.
How to test
Review the following pages in Chrome, Safari, FF, and Edge. Verify they work as expected: