Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redirect): disable follow redirect #95

Merged
merged 1 commit into from
Oct 26, 2021
Merged

feat(redirect): disable follow redirect #95

merged 1 commit into from
Oct 26, 2021

Conversation

rbioteau
Copy link
Member

Disable followRedirects by default and add a configuration options.
This can have an impact if a user was expecting a http -> https
redirection.
Feign request options was not inheriting from the okhttp configuration
for timeouts.

Fix BonitaClientIT as default layout and bootstrap theme are not
included in the bundle by default anymore.

@rbioteau
feat(redirect): disable follow redirect
d58d095 
Disable `followRedirects` by default and add a configuration options.
This can have an impact if a user was expecting a http -> https
redirection.
Feign request options was not inheriting from the okhttp configuration
for timeouts.

Fix BonitaClientIT as default layout and bootstrap theme are not
included in the bundle by default anymore.
@rbioteau rbioteau requested a review from uguy October 20, 2021 09:22
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rbioteau rbioteau merged commit 4348420 into dev Oct 26, 2021
@rbioteau rbioteau deleted the feat/disable_follow_redirect branch October 26, 2021 11:47
uguy added a commit that referenced this pull request Nov 29, 2021
@uguy @github-actions
@dependabot @rbioteau @baptistemesta @Shmayro
release(0.0.3): Release 0.0.3 (#116)
c567816 
* chore(deps): bump lombok from 1.18.18 to 1.18.20 (#50)

Bumps [lombok](https://github.com/rzwitserloot/lombok) from 1.18.18 to 1.18.20.
- [Release notes](https://github.com/rzwitserloot/lombok/releases)
- [Changelog](https://github.com/rzwitserloot/lombok/blob/master/doc/changelog.markdown)
- [Commits](projectlombok/lombok@v1.18.18...v1.18.20)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump actions/cache from 2.1.4 to 2.1.6 (#63)

Bumps [actions/cache](https://github.com/actions/cache) from 2.1.4 to 2.1.6.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.4...v2.1.6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump jackson-bom from 2.12.2 to 2.12.4 (#70)

Bumps [jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.12.2 to 2.12.4.
- [Release notes](https://github.com/FasterXML/jackson-bom/releases)
- [Commits](FasterXML/jackson-bom@jackson-bom-2.12.2...jackson-bom-2.12.4)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson:jackson-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump samuelmeuli/action-maven-publish from 1 to 1.4.0 (#57)

Bumps [samuelmeuli/action-maven-publish](https://github.com/samuelmeuli/action-maven-publish) from 1 to 1.4.0.
- [Release notes](https://github.com/samuelmeuli/action-maven-publish/releases)
- [Commits](samuelmeuli/action-maven-publish@v1...v1.4.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump everlytic/branch-merge from 1.1.0 to 1.1.2 (#68)

Bumps [everlytic/branch-merge](https://github.com/everlytic/branch-merge) from 1.1.0 to 1.1.2.
- [Release notes](https://github.com/everlytic/branch-merge/releases)
- [Commits](everlytic/branch-merge@1.1.0...1.1.2)

---
updated-dependencies:
- dependency-name: everlytic/branch-merge
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump assertj-core from 3.19.0 to 3.20.2 (#76)

Bumps [assertj-core](https://github.com/assertj/assertj-core) from 3.19.0 to 3.20.2.
- [Release notes](https://github.com/assertj/assertj-core/releases)
- [Commits](assertj/assertj@assertj-core-3.19.0...assertj-core-3.20.2)

---
updated-dependencies:
- dependency-name: org.assertj:assertj-core
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump maven-gpg-plugin from 1.6 to 3.0.1 (#77)

Bumps [maven-gpg-plugin](https://github.com/apache/maven-gpg-plugin) from 1.6 to 3.0.1.
- [Release notes](https://github.com/apache/maven-gpg-plugin/releases)
- [Commits](apache/maven-gpg-plugin@maven-gpg-plugin-1.6...maven-gpg-plugin-3.0.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-gpg-plugin
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump git-commit-id-plugin from 4.0.3 to 4.9.10 (#72)

Bumps git-commit-id-plugin from 4.0.3 to 4.9.10.

---
updated-dependencies:
- dependency-name: pl.project13.maven:git-commit-id-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump jacoco-maven-plugin from 0.8.6 to 0.8.7 (#78)

Bumps [jacoco-maven-plugin](https://github.com/jacoco/jacoco) from 0.8.6 to 0.8.7.
- [Release notes](https://github.com/jacoco/jacoco/releases)
- [Commits](jacoco/jacoco@v0.8.6...v0.8.7)

---
updated-dependencies:
- dependency-name: org.jacoco:jacoco-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Romain Bioteau <romain.bioteau@bonitasoft.com>

* update dependencies

Signed-off-by: Romain Bioteau <romain.bioteau@bonitasoft.com>

* chore(deps): bump actions/setup-java from 1 to 2.2.0 (#73)

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 1 to 2.2.0.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@v1...v2.2.0)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update setup-java step

Signed-off-by: Romain Bioteau <romain.bioteau@bonitasoft.com>

* feat(redirect): disable follow redirect (#95)

Disable `followRedirects` by default and add a configuration options.
This can have an impact if a user was expecting a http -> https
redirection.
Feign request options was not inheriting from the okhttp configuration
for timeouts.

Fix BonitaClientIT as default layout and bootstrap theme are not
included in the bundle by default anymore.

* chore(deps-dev): bump logback-classic from 1.2.5 to 1.2.6 (#90)

Bumps logback-classic from 1.2.5 to 1.2.6.

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-classic
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump jul-to-slf4j from 1.7.30 to 1.7.32 (#83)

Bumps [jul-to-slf4j](https://github.com/qos-ch/slf4j) from 1.7.30 to 1.7.32.
- [Release notes](https://github.com/qos-ch/slf4j/releases)
- [Commits](qos-ch/slf4j@v_1.7.30...v_1.7.32)

---
updated-dependencies:
- dependency-name: org.slf4j:jul-to-slf4j
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump swagger-annotations from 1.6.2 to 1.6.3 (#98)

Bumps swagger-annotations from 1.6.2 to 1.6.3.

---
updated-dependencies:
- dependency-name: io.swagger:swagger-annotations
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump maven-javadoc-plugin from 3.2.0 to 3.3.1 (#89)

Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.2.0 to 3.3.1.
- [Release notes](https://github.com/apache/maven-javadoc-plugin/releases)
- [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.2.0...maven-javadoc-plugin-3.3.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-javadoc-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump mockito-junit-jupiter from 3.11.2 to 4.0.0 (#93)

Bumps [mockito-junit-jupiter](https://github.com/mockito/mockito) from 3.11.2 to 4.0.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v3.11.2...v4.0.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-junit-jupiter
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump lombok from 1.18.20 to 1.18.22 (#99)

Bumps [lombok](https://github.com/projectlombok/lombok) from 1.18.20 to 1.18.22.
- [Release notes](https://github.com/projectlombok/lombok/releases)
- [Changelog](https://github.com/projectlombok/lombok/blob/master/doc/changelog.markdown)
- [Commits](projectlombok/lombok@v1.18.20...v1.18.22)

---
updated-dependencies:
- dependency-name: org.projectlombok:lombok
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump okhttp.version from 4.9.1 to 4.9.2 (#100)

Bumps `okhttp.version` from 4.9.1 to 4.9.2.

Updates `okhttp` from 4.9.1 to 4.9.2
- [Release notes](https://github.com/square/okhttp/releases)
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](square/okhttp@parent-4.9.1...parent-4.9.2)

Updates `logging-interceptor` from 4.9.1 to 4.9.2
- [Release notes](https://github.com/square/okhttp/releases)
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](square/okhttp@parent-4.9.1...parent-4.9.2)

---
updated-dependencies:
- dependency-name: com.squareup.okhttp3:okhttp
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: com.squareup.okhttp3:logging-interceptor
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump awaitility from 4.1.0 to 4.1.1 (#103)

Bumps [awaitility](https://github.com/awaitility/awaitility) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/awaitility/awaitility/releases)
- [Changelog](https://github.com/awaitility/awaitility/blob/master/changelog.txt)
- [Commits](awaitility/awaitility@awaitility-4.1.0...awaitility-4.1.1)

---
updated-dependencies:
- dependency-name: org.awaitility:awaitility
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(userTask): use the proper filter name (#94)

* chore(deps): bump testcontainers-bom from 1.16.0 to 1.16.2 (#101)

Bumps [testcontainers-bom](https://github.com/testcontainers/testcontainers-java) from 1.16.0 to 1.16.2.
- [Release notes](https://github.com/testcontainers/testcontainers-java/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-java@1.16.0...1.16.2)

---
updated-dependencies:
- dependency-name: org.testcontainers:testcontainers-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump assertj-core from 3.20.2 to 3.21.0 (#102)

Bumps [assertj-core](https://github.com/assertj/assertj-core) from 3.20.2 to 3.21.0.
- [Release notes](https://github.com/assertj/assertj-core/releases)
- [Commits](assertj/assertj@assertj-core-3.20.2...assertj-core-3.21.0)

---
updated-dependencies:
- dependency-name: org.assertj:assertj-core
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump junit-bom from 5.7.2 to 5.8.1 (#104)

Bumps [junit-bom](https://github.com/junit-team/junit5) from 5.7.2 to 5.8.1.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.7.2...r5.8.1)

---
updated-dependencies:
- dependency-name: org.junit:junit-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(feign): disable 404 decoder (#96)

404 response are handled in the BOnitaErrorDecode and throws
NotFoundExcpetion which is the expected behavior.

Enabling 404 decoder returns empty instances which is confusing.

* chore(deps): bump jackson-bom from 2.12.4 to 2.13.0 (#92)

Bumps [jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.12.4 to 2.13.0.
- [Release notes](https://github.com/FasterXML/jackson-bom/releases)
- [Commits](FasterXML/jackson-bom@jackson-bom-2.12.4...jackson-bom-2.13.0)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson:jackson-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump actions/setup-java from 2.2.0 to 2.3.1 (#91)

* chore(deps): bump actions/setup-java from 2.2.0 to 2.3.1

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2.2.0 to 2.3.1.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@v2.2.0...v2.3.1)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* update setup-java with temurin and cache management

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Romain Bioteau <romain.bioteau@bonitasoft.com>

* chore(deps): bump feign-bom from 11.6 to 11.7 (#105)

Bumps [feign-bom](https://github.com/openfeign/feign) from 11.6 to 11.7.
- [Release notes](https://github.com/openfeign/feign/releases)
- [Changelog](https://github.com/OpenFeign/feign/blob/master/CHANGELOG.md)
- [Commits](OpenFeign/feign@11.6...11.7)

---
updated-dependencies:
- dependency-name: io.github.openfeign:feign-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* enable followRedirect

* chore(deps): bump openapi-generator-maven-plugin from 5.2.1 to 5.3.0 (#97)

Bumps openapi-generator-maven-plugin from 5.2.1 to 5.3.0.

---
updated-dependencies:
- dependency-name: org.openapitools:openapi-generator-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(ci): stop using sonar for dependabot builds (#110)

* chore(deps-dev): bump logback-classic from 1.2.6 to 1.2.7 (#109)

Bumps logback-classic from 1.2.6 to 1.2.7.

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-classic
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump sonar-maven-plugin from 3.9.0.2155 to 3.9.1.2184 (#107)

Bumps [sonar-maven-plugin](https://github.com/SonarSource/sonar-scanner-maven) from 3.9.0.2155 to 3.9.1.2184.
- [Release notes](https://github.com/SonarSource/sonar-scanner-maven/releases)
- [Commits](SonarSource/sonar-scanner-maven@3.9.0.2155...3.9.1.2184)

---
updated-dependencies:
- dependency-name: org.sonarsource.scanner.maven:sonar-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump okhttp.version from 4.9.2 to 4.9.3 (#113)

Bumps `okhttp.version` from 4.9.2 to 4.9.3.

Updates `okhttp` from 4.9.2 to 4.9.3
- [Release notes](https://github.com/square/okhttp/releases)
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](square/okhttp@parent-4.9.2...parent-4.9.3)

Updates `logging-interceptor` from 4.9.2 to 4.9.3
- [Release notes](https://github.com/square/okhttp/releases)
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md)
- [Commits](square/okhttp@parent-4.9.2...parent-4.9.3)

---
updated-dependencies:
- dependency-name: com.squareup.okhttp3:okhttp
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: com.squareup.okhttp3:logging-interceptor
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps-dev): bump mockito-junit-jupiter from 4.0.0 to 4.1.0 (#112)

Bumps [mockito-junit-jupiter](https://github.com/mockito/mockito) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v4.0.0...v4.1.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-junit-jupiter
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): bump actions/cache from 2.1.6 to 2.1.7 (#115)

Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat(users): add create group/role/profile (#108)

Co-authored-by: haroun.elalami <haroun.elalami@bonitasoft.com>

* feat(bdm): result dynamic types with lazy get via a proxy (#114)

* chore(openapi): use 0.0.4 version of bonita openapi
* chore(bdm): bdm custom queries support with dynamic response types

Co-authored-by: Romain Bioteau <romain.bioteau@bonitasoft.com>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Romain Bioteau <romain.bioteau@bonitasoft.com>
Co-authored-by: Adrien <adrien.lachambre@bonitasoft.com>
Co-authored-by: Baptiste Mesta <baptiste.mesta@bonitasoft.com>
Co-authored-by: haroun.elalami <haroun.elalami@bonitasoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uguy uguy Awaiting requested review from uguy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rbioteau