Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix foreign key = 0 not fetching related object #1639
Conversation
src/relation.js
Outdated
| @@ -411,7 +411,7 @@ export default RelationBase.extend({ | ||
| const formatted = model.format(_.clone(model.attributes)); | ||
| groupedKey = formatted[keyColumn]; | ||
| } | ||
| if (groupedKey) { | ||
| if (groupedKey !== null) { |
This comment has been minimized.
This comment has been minimized.
ricardograca
referenced this pull request
Nov 7, 2017
Closed
Cannot load a related model with foreign key ID = 0 #1685
This comment has been minimized.
This comment has been minimized.
ricardograca
added
bug
weak/no tests
labels
Dec 27, 2017
ricardograca
referenced this pull request
Jan 7, 2018
Merged
Add test to check ability to eager load with foreign key with value 0 #1735
This comment has been minimized.
This comment has been minimized.
|
I just added a test for this in #1735. |
ricardograca
merged commit 83b6f65
into
bookshelf:master
Jan 7, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
added a commit
that referenced
this pull request
Jan 7, 2018
ricardograca
referenced this pull request
Feb 2, 2018
Closed
Getting related with parent id is zero returns no relations #1752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ollija commentedSep 4, 2017
•
edited by ricardograca
Fix foreign key = 0 not fetching related object
Introduction
Fixes fetching relations with foreign key = 0.
Currently inside eagerPair-method the foreign keys are just checked for being falsy,
leaving the related instance out of the parent's relations if the FK is 0.
Fixes #1685.
Motivation
This PR enables fetching relations with value 0 as the foreign key.
Proposed solution
Compare the
groupedKey-variable (which stores the foreign key) through lodashesisNil-method inside the if-block, instead of just checking for a falsy value. This way 0 is a valid value, butnull/undefinedvalues are not.