Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test suite #3

Merged
merged 1 commit into from
Apr 3, 2014
Merged

Refactor test suite #3

merged 1 commit into from
Apr 3, 2014

Conversation

bendrucker
Copy link
Member

Wanted to do this as part of the process of diagnosing bookshelf/bookshelf#310. Changes include:

  • Swapping Q for Bluebird to take advantage of Bluebird's onPossiblyUnhandledRejection feature
  • Updating to Mocha 1.8.x which has native promise support — you can return a promise to make a test async rather than needing to call the test callback
  • Using Chai and Sinon (+ plugins) for more expressive and specific assertions
  • General cleanup of tests so that each test covers more specific functionality

tgriesser added a commit that referenced this pull request Apr 3, 2014
@tgriesser tgriesser merged commit 98bdb97 into bookshelf:master Apr 3, 2014
@tgriesser
Copy link
Member

Thanks.

@bendrucker
Copy link
Member Author

Closes #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants