Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for rolling_variance #1

Closed
wants to merge 2 commits into from

Conversation

PieterBOber
Copy link

Pull request for adding rolling_variance and rolling_moment to boost.accumulators.

…ng 'rolling_mean' into a lazy and immediate implementation. Documentation is updated accordingly.
@ericniebler
Copy link
Member

Wow, looks really great. A million thanks for your contribution. I just merged this into the develop branch. (In the future, you should make your pull requests against develop instead of master. The UI doesn't make this intuitive, I know.)

@PieterBOber
Copy link
Author

Thanks Eric, happy to hear that things worked out – and thanks for pointing that pull request issue out - I’m still learning.

Best,

  •      Bas
    

From: Eric Niebler [mailto:notifications@github.com]
Sent: Saturday, June 14, 2014 11:04 PM
To: boostorg/accumulators
Cc: PieterBOber
Subject: Re: [accumulators] Pull request for rolling_variance (#1)

Wow, looks really great. A million thanks for your contribution. I just merged this into the develop branch. (In the future, you should make your pull requests against develop instead of master. The UI doesn't make this intuitive, I know.)


Reply to this email directly or view it on GitHub #1 (comment) . https://github.com/notifications/beacon/7852542__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxODM5OTA2OSwiZGF0YSI6eyJpZCI6MzQ1MTkyNDl9fQ==--0456ac135dad678fced41e65ec6de8188abb5a09.gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants