-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssl_stream.hpp: outdated signature of set_verify_mode/set_verify_callback #1247
Comments
If you want to submit a pull request, that would be an easy way to get your name into the list of contributors! Or I can do it, up to you. |
The whole file probably needs to be reviewed and obviously some tests need to be written as well. Currently I just don't have the time to do that. |
Hmm...I don't think we need tests, that's a bit extreme. This just passes through the calls to the underlying asio |
This issue has been open for a while with no activity, has it been resolved? |
This looks like it hasn't been resolved yet? If no one is currently working on it, I can submit a pull request for this. |
That would be wonderful |
The signature of
set_verify_mode
andset_verify_callback
changed with boost 1.66, so using the ones ofssl_stream
will cause a compilation failure.It's quite possible, that there are more mismatching signatures - I didn't check the whole file.
https://www.boost.org/doc/libs/1_65_0/doc/html/boost_asio/reference/ssl__stream/set_verify_callback.html
https://www.boost.org/doc/libs/1_68_0/doc/html/boost_asio/reference/ssl__stream/set_verify_callback.html
https://www.boost.org/doc/libs/1_65_0/doc/html/boost_asio/reference/ssl__stream/set_verify_depth.html
https://www.boost.org/doc/libs/1_68_0/doc/html/boost_asio/reference/ssl__stream/set_verify_depth.html
The text was updated successfully, but these errors were encountered: