Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl_stream.hpp: outdated signature of set_verify_mode/set_verify_callback #1247

Closed
firewave opened this issue Sep 18, 2018 · 6 comments
Closed
Labels
Spec Adherance to RFC specifications

Comments

@firewave
Copy link

The signature of set_verify_mode and set_verify_callback changed with boost 1.66, so using the ones of ssl_stream will cause a compilation failure.

It's quite possible, that there are more mismatching signatures - I didn't check the whole file.

https://www.boost.org/doc/libs/1_65_0/doc/html/boost_asio/reference/ssl__stream/set_verify_callback.html
https://www.boost.org/doc/libs/1_68_0/doc/html/boost_asio/reference/ssl__stream/set_verify_callback.html

https://www.boost.org/doc/libs/1_65_0/doc/html/boost_asio/reference/ssl__stream/set_verify_depth.html
https://www.boost.org/doc/libs/1_68_0/doc/html/boost_asio/reference/ssl__stream/set_verify_depth.html

@vinniefalco
Copy link
Member

If you want to submit a pull request, that would be an easy way to get your name into the list of contributors! Or I can do it, up to you.

@firewave
Copy link
Author

The whole file probably needs to be reviewed and obviously some tests need to be written as well. Currently I just don't have the time to do that.

@vinniefalco
Copy link
Member

Hmm...I don't think we need tests, that's a bit extreme. This just passes through the calls to the underlying asio ssl_stream.

@stale
Copy link

stale bot commented Nov 17, 2018

This issue has been open for a while with no activity, has it been resolved?

@stale stale bot added the Stale No recent activity label Nov 17, 2018
@vinniefalco vinniefalco added the Spec Adherance to RFC specifications label Nov 17, 2018
@stale stale bot removed the Stale No recent activity label Nov 17, 2018
@octobanana
Copy link
Contributor

This looks like it hasn't been resolved yet? If no one is currently working on it, I can submit a pull request for this.

@vinniefalco
Copy link
Member

That would be wonderful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spec Adherance to RFC specifications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants