Fix compiler version check on macOS #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #440.
5 tasks
asfgit
pushed a commit
to apache/kudu
that referenced
this pull request
Apr 2, 2020
The latest Catalina update broke boost due to bad version parsing/checks. This patch applies the fix from the below pull request as a patch: boostorg/build#560 See boostorg/build#440 for additional context. Change-Id: Ie6bb488dcadf215be708ae1b1e89ddd77bd30074 Reviewed-on: http://gerrit.cloudera.org:8080/15632 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <adar@cloudera.com> Reviewed-by: Alexey Serbin <aserbin@cloudera.com> Reviewed-by: Andrew Wong <awong@cloudera.com>
This was referenced Apr 8, 2020
mjmacleod
added a commit
to muntorg/munt-official
that referenced
this pull request
Apr 20, 2020
Breakage is in boost, with bjam picking up wrong compiler version. Fix is relatively simple, backported a patch from boost which will be included in newer boost versions (.73 onwards) when we upgrade in future See: boostorg/build#440 boostorg/build#560
mjmacleod
added a commit
to muntorg/munt-official
that referenced
this pull request
Apr 20, 2020
Breakage is in boost, with bjam picking up wrong compiler version. Fix is relatively simple, backported a patch from boost which will be included in newer boost versions (.73 onwards) when we upgrade in future See: boostorg/build#440 boostorg/build#560
mjmacleod
added a commit
to muntorg/munt-official
that referenced
this pull request
Apr 20, 2020
Breakage is in boost, with bjam picking up wrong compiler version. Fix is relatively simple, backported a patch from boost which will be included in newer boost versions (.73 onwards) when we upgrade in future See: boostorg/build#440 boostorg/build#560
nieder
added a commit
to fink/fink-distributions
that referenced
this pull request
Apr 28, 2020
From upstream patch. See: boostorg/build#440 boostorg/build#560
svarnau
added a commit
to svarnau/yugabyte-db-thirdparty
that referenced
this pull request
May 7, 2020
Patch boost build from boostorg/build#560
mbautin
pushed a commit
to yugabyte/yugabyte-db-thirdparty
that referenced
this pull request
May 7, 2020
Patch boost build from boostorg/build#560
svarnau
added a commit
to yugabyte/yugabyte-db
that referenced
this pull request
May 7, 2020
Summary: Patch boost build from boostorg/build#560 Test Plan: Mac Catalina latop: yb_build.sh --clean-thirdparty release Reviewers: bogdan, wesley, amitanand, mikhail Reviewed By: mikhail Subscribers: devops Differential Revision: https://phabricator.dev.yugabyte.com/D8433
str4d
added a commit
to str4d/zcash
that referenced
this pull request
Oct 5, 2020
- The old patch is no longer necessary because of this upstream fix: boostorg/build#560 - Boost 1.72 removed a <deque> from an include, which exposed a missing include in src/httpserver.cpp. - Boost 1.73 moved function placeholders into the boost::placeholders namespace. - The new patch is a fix from just after Boost 1.74 was released, fixing a warning that was missed.
abitmore
added a commit
to bitshares/homebrew-boost
that referenced
this pull request
Nov 1, 2020
abitmore
added a commit
to bitshares/homebrew-boost
that referenced
this pull request
Nov 1, 2020
abitmore
added a commit
to bitshares/homebrew-boost
that referenced
this pull request
Nov 1, 2020
Flamefire
added a commit
to Flamefire/s25client
that referenced
this pull request
Dec 18, 2020
Flamefire
added a commit
to Flamefire/s25client
that referenced
this pull request
Dec 18, 2020
Flamefire
added a commit
to Flamefire/s25client
that referenced
this pull request
Dec 18, 2020
Flow86
pushed a commit
to Return-To-The-Roots/s25client
that referenced
this pull request
Dec 19, 2020
Asherda
pushed a commit
to Asherda/VerusCoin
that referenced
this pull request
May 17, 2023
- The old patch is no longer necessary because of this upstream fix: boostorg/build#560 - Boost 1.72 removed a <deque> from an include, which exposed a missing include in src/httpserver.cpp. - Boost 1.73 moved function placeholders into the boost::placeholders namespace. - The new patch is a fix from just after Boost 1.74 was released, fixing a warning that was missed.
Asherda
pushed a commit
to VerusCoin/VerusCoin
that referenced
this pull request
May 18, 2023
- The old patch is no longer necessary because of this upstream fix: boostorg/build#560 - Boost 1.72 removed a <deque> from an include, which exposed a missing include in src/httpserver.cpp. - Boost 1.73 moved function placeholders into the boost::placeholders namespace. - The new patch is a fix from just after Boost 1.74 was released, fixing a warning that was missed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #440.
This fixes Xcode 11.4 builds.
gccis just an alias toclangin Xcode, but-dumpversionreturned a fixed 4.2.1 for compatibility reasons (the last version ofgccXcode shipped). Xcode 11.4 changed this to now return the Apple Clang version, which is now 11.0.3. Because the version checks were a lexicographical comparison, "11.0.3" was seen as < "4.0.0".