Fix callcc functionality for g++-4.9 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaoWen
commented
Apr 20, 2017
| @@ -451,7 +452,8 @@ class continuation { | |||
| template< | |||
| typename Fn, | |||
| typename ... Arg, | |||
| typename = detail::disable_overload< continuation, Fn > | |||
| typename = detail::disable_overload< continuation, Fn >, | |||
| typename = detail::disable_overload< std::allocator_arg_t, Fn > | |||
There was a problem hiding this comment.
This extra disable_overload fixes the compiler error for me.
| @@ -354,15 +355,15 @@ class continuation { | |||
| template< typename Fn, typename ... Arg > | |||
| continuation resume_with( Fn && fn, Arg ... arg) { | |||
| BOOST_ASSERT( nullptr != t_.fctx); | |||
| auto tpl = std::make_tuple( std::forward< Fn >( fn), std::forward< Arg >( arg) ... ); | |||
There was a problem hiding this comment.
Note that the type of tpl here is std::tuple<Fn, Arg...>.
| detail::transfer_t context_ontop( detail::transfer_t t) { | ||
| auto p = static_cast< std::tuple< Fn, std::tuple< Arg ... > > * >( t.data); |
There was a problem hiding this comment.
Note that the expected type for t.data is std::tuple< Fn, std::tuple< Arg ... > > *, which does not correspond to the argument type declared on line 357 below.
My guess is that the C++ library implementation for std::tuple changed between g++-4.9 and g++-5, which is why this bad cast happened to work with newer g++ versions but fails with version 4.9.
This was referenced Apr 21, 2017
|
hmm, did noticed that mistake - strage that I got fooled by so much compilers (clang, msvc, intel compile this code). |
olk
added a commit
that referenced
this pull request
Apr 22, 2017
Fix callcc functionality for g++-4.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the resolution issue discussed in #52 and #54 that caused compiler errors when using g++-4.9. Also fixes a bad cast that was causing bad values to be passed as arguments into continuations.