Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protected class members for shared_work scheduler #112

Closed
danichcr72 opened this issue Feb 23, 2017 · 3 comments
Closed

protected class members for shared_work scheduler #112

danichcr72 opened this issue Feb 23, 2017 · 3 comments

Comments

@danichcr72
Copy link

Hi,

First of all, thanks for the great contributions of fibers to the boost libraries!

I used fibers to build a runtime system for a distributed database system and had the need to create a custom scheduler. The scheduler that I needed was pretty similar to your provided shared_work scheduler with the caveat that the "system" or dispatcher fibers must be scheduled with some frequency to garbage-collect terminated tasks. I proceeded to derive my scheduler from your shared_work but unfortunately needed to change your code to declare the members of the shared_work class to be protected instead of private.

Would it be possible to change these class members to be protected so that they can be accessed by derived classes?

Thanks,

Daniel Chavarria
Trovares Inc.

@olk
Copy link
Member

olk commented Feb 24, 2017

I plan to re-factor the API for custom-schedulers - but unfortunately I'm very busy.

@olk
Copy link
Member

olk commented Apr 2, 2017

related to #113

@olk
Copy link
Member

olk commented Apr 30, 2017

Please, use work_stealing scheduler instead of shared_work. work_stealing is much faster and does schedule dispatcher fibers correctly.
But could you show me your modifications, please?

@olk olk closed this as completed Apr 30, 2017
Romain-Geissler-1A pushed a commit to Romain-Geissler-1A/fiber that referenced this issue Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants