-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protected class members for shared_work scheduler #112
Comments
I plan to re-factor the API for custom-schedulers - but unfortunately I'm very busy. |
related to #113 |
Please, use work_stealing scheduler instead of shared_work. work_stealing is much faster and does schedule dispatcher fibers correctly. |
Romain-Geissler-1A
pushed a commit
to Romain-Geissler-1A/fiber
that referenced
this issue
Apr 3, 2020
Revert "S390x Implementation: WIP"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
First of all, thanks for the great contributions of fibers to the boost libraries!
I used fibers to build a runtime system for a distributed database system and had the need to create a custom scheduler. The scheduler that I needed was pretty similar to your provided shared_work scheduler with the caveat that the "system" or dispatcher fibers must be scheduled with some frequency to garbage-collect terminated tasks. I proceeded to derive my scheduler from your shared_work but unfortunately needed to change your code to declare the members of the shared_work class to be protected instead of private.
Would it be possible to change these class members to be protected so that they can be accessed by derived classes?
Thanks,
Daniel Chavarria
Trovares Inc.
The text was updated successfully, but these errors were encountered: