Fix undefined behavior in detail::copy #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call the detail versions, which take pointers, rather than converting the pointers to references and back (which is UB).
|
Could you please merge this? This is causing segfaults in production. Thanks! |
|
Yeah I should've been more clear, this causes crashes. |
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 19, 2018
PR: 229888 Approved by: maintainer Obtained from: boostorg/filesystem#71 MFH: 2018Q3 (runtime fix, null pointer dereference) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@474979 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 19, 2018
PR: 229888 Approved by: maintainer Obtained from: boostorg/filesystem#71 MFH: 2018Q3 (runtime fix, null pointer dereference)
|
The code segment below demonstrates the undefined behaviour (in my case leading to segfaults): See here for a more detailed description of the problem (adding the patch to the freebsd ports tree): https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229888 |
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jul 19, 2018
Fix runtime null pointer dereference (undefined behavior) PR: 229888 Approved by: maintainer Obtained from: boostorg/filesystem#71 Approved by: ports-secteam (runtime fix blanket)
swills
pushed a commit
to swills/freebsd-ports
that referenced
this pull request
Jul 20, 2018
PR: 229888 Approved by: maintainer Obtained from: boostorg/filesystem#71 MFH: 2018Q3 (runtime fix, null pointer dereference) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@474979 35697150-7ecd-e111-bb59-0022644237b5
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Jul 20, 2018
PR: 229888 Approved by: maintainer Obtained from: boostorg/filesystem#71 MFH: 2018Q3 (runtime fix, null pointer dereference) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@474979 35697150-7ecd-e111-bb59-0022644237b5
|
@Beman could you please take a look and merge this patch if there are no concerns with the code? |
biadasiewicz
pushed a commit
to biadasiewicz/filesystem
that referenced
this pull request
Sep 18, 2018
|
Perhaps the CI suite should be running UBSAN and static code analyses? |
|
It is running UBSAN. |
|
Apologies, I looked at the build results for the PR which is 7 months old. |
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 1, 2021
Fix runtime null pointer dereference (undefined behavior) PR: 229888 Approved by: maintainer Obtained from: boostorg/filesystem#71 Approved by: ports-secteam (runtime fix blanket)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call the detail versions, which take pointers, rather than converting the pointers to references and back (which is UB).