[strategies] Fix spherical closest_points strategy for PointOfSegment different than model::point

[awulkiew]

Currently it fails to compile due to multiple return types.

[vissarion]

thanks!

[barendgehrels]

Thanks
(we could add a test for this situation)

[awulkiew]

Thanks (we could add a test for this situation)

@barendgehrels would you prefer me to create a separate test case for user-defined types or maybe to replace BG models in all of them? If it's the latter then maybe we should use types different than BG models in all of the tests?

[barendgehrels]

Thanks (we could add a test for this situation)

@barendgehrels would you prefer me to create a separate test case for user-defined types or maybe to replace BG models in all of them? If it's the latter then maybe we should use types different than BG models in all of the tests?

It would indeed be good that every algorithm also contains one test for one different type. To test type diversity. The algorithms themselves can be tested with the standard type.

So in this case I would suggest to create a separate test case for user-defined types.

There is often also constness etc involved (I'm not asking that right now). Many of our test (not generating points) will not compile, probably. And algorithms working on two or three input/output's might contain a test case where different types (or even coordinate types) are involved. But most tests don't do this.

I made this remark because there was a particular bug fixed related to this - then it would be good to add such a case (if you have the time).