-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] add cmake lists for 143 algorithms #1280
[test] add cmake lists for 143 algorithms #1280
Conversation
c3836ce
to
933f35a
Compare
|
||
foreach(item IN ITEMS | ||
perimeter | ||
perimeter_base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two above (were duplicate) are quite similar, and quite short, we can merge them later.
But I wanted this PR to be CMake only.
distance_geo_pl_l | ||
distance_se_geo_pl_pl | ||
distance_se_pl_l | ||
distance_se_pl_pl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these lists are made by using relevant lines from the Jamfile
and stripping all but the filename.
pl_l | ||
pl_pl | ||
) | ||
boost_geometry_add_unit_test("algorithms_closest_points" ${item}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is the only suffixing the name itself to the algorithms, for obvious reasons
933f35a
to
4386158
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think it is very useful to have a complete cmake support for tests.
Regarding perimeter tests, should you also move test_perimeter.hpp
in perimeter
directory?
There is no cmake related testing in CI, we should include it. See also #1273 (comment)
4386158
to
dbcf1f3
Compare
Sure, thank you! I missed it. Fixed. |
dbcf1f3
to
e3ad896
Compare
The algorithms should be complete now. But there is still some work to do for several folders (among others: |
Thanks, looking forward to it. |
e3ad896
to
fa10138
Compare
fa10138
to
11b5398
Compare
@vissarion Next PR will add the next list, and then it should be complete.
|
This PR
perimeter
: it moves those two algorithms to their folderThey all pass on my Mac.
Do we have this CMake flavor on CI already?