Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] add cmake lists for 143 algorithms #1280

Merged
merged 1 commit into from
May 21, 2024

Conversation

barendgehrels
Copy link
Collaborator

@barendgehrels barendgehrels commented May 9, 2024

This PR

  • adds 143 algorithms
  • because this caused a duplicate in perimeter : it moves those two algorithms to their folder

They all pass on my Mac.
Do we have this CMake flavor on CI already?


foreach(item IN ITEMS
perimeter
perimeter_base
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two above (were duplicate) are quite similar, and quite short, we can merge them later.
But I wanted this PR to be CMake only.

distance_geo_pl_l
distance_se_geo_pl_pl
distance_se_pl_l
distance_se_pl_pl
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these lists are made by using relevant lines from the Jamfile and stripping all but the filename.

pl_l
pl_pl
)
boost_geometry_add_unit_test("algorithms_closest_points" ${item})
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is the only suffixing the name itself to the algorithms, for obvious reasons

Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think it is very useful to have a complete cmake support for tests.

Regarding perimeter tests, should you also move test_perimeter.hpp in perimeter directory?

There is no cmake related testing in CI, we should include it. See also #1273 (comment)

@barendgehrels
Copy link
Collaborator Author

Regarding perimeter tests, should you also move test_perimeter.hpp in perimeter directory?

Sure, thank you! I missed it. Fixed.

@barendgehrels
Copy link
Collaborator Author

Thanks, I think it is very useful to have a complete cmake support for tests.

The algorithms should be complete now. But there is still some work to do for several folders (among others: policies , iterators, formulas)

@barendgehrels
Copy link
Collaborator Author

There is no cmake related testing in CI, we should include it. See also #1273 (comment)

Thanks, looking forward to it.

@barendgehrels barendgehrels changed the title [test] add cmake lists for 140 algorithms [test] add cmake lists for 143 algorithms May 11, 2024
@barendgehrels
Copy link
Collaborator Author

@vissarion
I automated it a bit (not checked in) with help of ChatGPT, last pushes were from that effort. That also adds detail/sections which I missed before.

Next PR will add the next list, and then it should be complete.

add_subdirectory(core)
add_subdirectory(concepts)
add_subdirectory(geometries)
add_subdirectory(arithmetic)
add_subdirectory(formulas)
add_subdirectory(iterators)
add_subdirectory(strategies)
add_subdirectory(policies)
add_subdirectory(io)
add_subdirectory(srs)

@barendgehrels barendgehrels merged commit 69588ff into boostorg:develop May 21, 2024
23 checks passed
@barendgehrels barendgehrels deleted the test/add-cmake-lists branch May 21, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants