Allow key_of_value in treap to use a type unrelated to the type used for priority checking #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for priority checking.
priority_of_value<> and priority<> follow the same basic semantics as key_of_value<> and compare<>. This allows the priority type to be unrelated to the key type when key_of_value<> is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix issue #35
In commit
4cf3898 the value used in priority comparison is the result of applying key_of_value. This doesn't seem to be intentional, and stops common cases which were previously allowed from working.
This change goes back to using the value type for priority comparison.