Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #43 (unwanted ADL issues) #44

Merged
merged 3 commits into from
Sep 22, 2018

Conversation

morinmorin
Copy link
Member

No description provided.

@Lastique Lastique merged commit b844c8d into boostorg:develop Sep 22, 2018
@Lastique
Copy link
Member

Thanks.

@morinmorin morinmorin deleted the fix/unwanted_adl branch September 22, 2018 13:38
@Lastique
Copy link
Member

@morinmorin I have reverted the change (but not the tests) made by this PR. See 06875a7. Feel free to take a look at the problem.

@morinmorin
Copy link
Member Author

I submitted PR to Boost.Range (boostorg/range#75), which moves distance into ADL barrier namespace and pulls the name via a using-directive.

However, testing on that PR fails now, since Boost.Range's PR and Boost.Iterator's PR need to be applied in sync.

@Lastique
Copy link
Member

I've reapplied your change and also added a test to check compatibility with boost::distance from Boost.Range.

@pdimov
Copy link
Member

pdimov commented Oct 1, 2018

Let me know when this is merged to master so that I can merge Range.

@Lastique
Copy link
Member

Lastique commented Oct 1, 2018

Just merged it, thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants