Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handler not invoked correctly in multi-byte UTF8 sequences, part 2 #240

Closed
rtobar opened this issue Sep 1, 2020 · 2 comments
Closed

Handler not invoked correctly in multi-byte UTF8 sequences, part 2 #240

rtobar opened this issue Sep 1, 2020 · 2 comments
Assignees
@sdkrystian

Comments

@rtobar
Copy link

rtobar commented Sep 1, 2020

This was fixed for writes of size 1 in #162, but apparently not for the general case, see rtobar@6d766ef for a test reproducing further errors plus a new example string that breaks.
sdkrystian added a commit to sdkrystian/json that referenced this issue Sep 1, 2020
@sdkrystian
Flush when parsing UTF-8
82318ef 
fix boostorg#240
@sdkrystian sdkrystian mentioned this issue Sep 1, 2020
Closed
@sdkrystian
Copy link
Member

sigh I forgot to flush characters preceding UTF-8 byte sequences. My bad.

sdkrystian added a commit to sdkrystian/json that referenced this issue Sep 1, 2020
@sdkrystian
Flush when parsing UTF-8
08bce7d 
fix boostorg#240
@rtobar
Copy link
Author

rtobar commented Sep 2, 2020

Looks good, thanks!

@rtobar rtobar mentioned this issue Apr 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdkrystian sdkrystian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flush when parsing UTF-8 sdkrystian/json
2 participants
@rtobar @sdkrystian