-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal changes to allow single move only values to be pushed and poped #27
Conversation
Any feedback would be appreciated. |
@timblechmann any feedback appreciated. |
let's focus on #31 (this one breaks c++98 compatibility btw) |
@timblechmann this should not be closed as this PR enables different things than #31. I think after over a year of waiting you should invest more time than to just close it. This one is not 'as developed' because it has received NO feedback. |
@timblechmann I don't think that's an argument. Move-able and move-only types added after c++98 really broke lock_free as it does not support them and its been 6 years. |
@tnovotny some projects are bound to older compilers for various reasons. new boost libraries may choose not to support them, but older libraries should not fail to compile after a library update. if new functionality is added, it will have to be guarded by the corresponding config macros. if you're improving the PR to make it compatible with c++98 (i'm fine with just not supporting movable types rather than using boost's move emulation), i'm more than happy to merge this PR and close the other one. |
@timblechmann I'm not a versed boost-developer, so a quick question. Should I use the |
@tnovotny yes |
Since this one was closed I added an updated PR as version as #41. |
I have tried to keep the changes minimal.