Fixed compilation error on MinGW-w64. #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behavior of windres.exe to read the output of the preprocessor is using popen. However, the popen implementation may be buggy on some non-English hosts, which would cause a compilation error like this: windres.exe: can't open file `page:': Invalid argument Fix by adding '--use-temp-file' option and windres.exe will use a temporary file to read instead of using opoen. Signed-off-by: ik <hello_ik@outlook.com>
|
Should Boost.Build be modified the same way? |
I haven't tried compiling this library through b2, don't known if it can work or not. I will test it tomorrow, BTW, bootstrap of b2 itself does not work because of the same problem, I'd like to create a PR for that later. |
|
The error doesn't occur if the library is built with b2. Support for the event log is actually disable since b2 only support mc.exe but not GNU's windmc.exe. |
|
Ok, thanks for checking. And for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of windres.exe to read the output of the preprocessor is using popen. However, the popen implementation may be buggy on some non-English hosts, which would cause a compilation error like this:
It can be fixed by adding --use-temp-file option and windres.exe will use a temporary file to read instead of using opoen. I also tried compiling with the option on English-only locale and it also works fine, so it is probably a good idea to add it.