Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark none instances as inline variables #75

Closed
wants to merge 1 commit into from
Closed

Mark none instances as inline variables #75

wants to merge 1 commit into from

Conversation

Lastique
Copy link
Member

This should avoid duplicating none instances in all translation units.

Closes #33.

@Lastique
Marked none instances as inline variables.
1f84919 
This should avoid duplicating none instances in all translation units.

Closes boostorg#33.
@akrzemi1
Copy link
Member

Thanks for the PR. I can see that BOOST_INLINE_VARIABLE is only defined in branch develop. To be on the safe side I'll wait until it is merged to master.

@Lastique
Copy link
Member Author

Closed by 9ed20cb.

@Lastique Lastique closed this Dec 19, 2019
@Lastique Lastique deleted the inline_none branch December 19, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

boost::none gets a separate instance in each translation unit
2 participants
@Lastique @akrzemi1