Initialize m_null and m_base #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the cases where we were not initializing m_null and m_base, instead we initialize them to default values. This simplifies the logic around assigning to them significantly and silences Coverity CID10550.
|
This breaks https://svn.boost.org/trac/boost/ticket/3632. Basically you cannot assign from a default-constructed (singular) iterator. Explicitly default constructing the remaining members will do no harm, but it has no positive effect either except to shut Coverty up of course. |
jzmaddock
pushed a commit
that referenced
this pull request
Nov 13, 2014
|
See ddd4820 |
This was referenced Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cases where we were not initializing m_null and m_base, instead we initialize them to default values. This simplifies the logic around assigning to them significantly and silences Coverity CID10550.