Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linking with Boost.System #266

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

Lastique
Copy link
Member

Since Boost.System is now header-only, no need to link with the library.

Since Boost.System is now header-only, no need to link with the library.
@viboes
Copy link
Collaborator

viboes commented Jan 15, 2019

Humm, what happens if a User wants to have Boost.Thread linked with Boost.System?

BTW, Boost.Chrono is also header only, so shouldn't Boost.Thread remove also the link with Boost.Chrono if we apply your logic?

I believe that at the end it is up to the user to select his configuration, isn't it?

I would appreciate a patch of the build system that is able to configure Boost.Thread/Boost.Chrono so that it can be build either linking with Boost.Chrono/Boost.System or not.

@viboes
Copy link
Collaborator

viboes commented Jan 15, 2019

Oh, I see that Boost.Thread link conditionaly with Boost.Chrono depending on whether we are building with threadapi=pthread or not.

I believe thsi should be independent of the value of threadapi.

How other non-header only libraries are configured in Boost?
Which ones depend on other Boost libraries?
Is there something that it is agreed on in Boost?

@Lastique
Copy link
Member Author

Maybe you misunderstood me. Boost.System is unconditionally header-only now, there's no config option to make it otherwise. Its compiled library is empty and it only exists to avoid breaking dependent libraries and applications. Given this, why would anyone want to link with it or have a config option in Boost.Thread? What is your reason in keeping the linking dependency?

I'm not sure what's the situation with Boost.Chrono, this PR is not about it. However, IMHO, if Boost.Chrono can be (or is) header-only without sacrificing its features or other major compromises, I don't see why it shouldn't be.

@viboes
Copy link
Collaborator

viboes commented Jan 16, 2019

Sorry, I was not aware that Boost.System had nothing inside the binary library now.
This change completely the context.

@viboes viboes merged commit 085c9c6 into boostorg:develop Jan 16, 2019
@Lastique Lastique deleted the remove_linking_system branch January 16, 2019 22:21
@viboes viboes added this to the 1.70 milestone Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants