Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit tests around use of scoped_allocator_adaptor to emulat… #31

Merged
merged 7 commits into from
Nov 15, 2021

Conversation

cmazakas
Copy link
Member

…e issue #22

@vinniefalco
Copy link
Member

What's going on with the build failures?

@cmazakas
Copy link
Member Author

cmazakas commented Oct 4, 2021

What's going on with the build failures?

Good news, I'm able to replicate the test failure locally. It only manifested in msvc 16.11.3.

I was using 16.11.1 and for some reason couldn't get it to fail so I updated my Visual Studio install and lo and behold, I have a local failure.

@cmazakas
Copy link
Member Author

The remaining test failure on AppVeyor seems to be a known issue. I'll leave the PR as-is until it gets fixed upstream and then we can merge in.

@cmazakas cmazakas closed this Oct 18, 2021
@cmazakas cmazakas reopened this Oct 18, 2021
@pdimov
Copy link
Member

pdimov commented Oct 18, 2021

In cases like these, when just one test needs /boost//filesystem, it's better to put the library requirement on the test itself, rather than in the project requirements. (Project requirements apply to every target in the project.)

The easiest way to do this is run unordered/scoped_allocator.cpp /boost//filesystem, but you can use a <library> requirement as well, if you prefer.

(As an example of the difference, if building Filesystem fails, putting it in the project requirements will cause all the tests to fail, whereas putting it on one test will only cause that one test to fail in this case.)

@pdimov pdimov merged commit 1e553df into boostorg:develop Nov 15, 2021
@cmazakas cmazakas deleted the scoped-alloc-tests branch December 28, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants