Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid undefining BOOST_AUTO_LINK_NOMANGLE if it was previously defined. #94

Closed
tomy2105 opened this issue Mar 28, 2019 · 2 comments · Fixed by #95
Closed

Avoid undefining BOOST_AUTO_LINK_NOMANGLE if it was previously defined. #94

tomy2105 opened this issue Mar 28, 2019 · 2 comments · Fixed by #95

Comments

@tomy2105
Copy link
Contributor

Undefining BOOST_AUTO_LINK_NOMANGLE, if it was previously defined, breaks desired behavior of all the boost libraries included after uuid.

Suddenly you will get situation where half of headers link against libname.lib and other half to "fully qualified library name".lib.

@ColinChargyBentley
Copy link

Hi,
I've left a comment in #95 (comment) about the same kind of bad behavior with BOOST_AUTO_LINK_TAGGED or BOOST_AUTO_LINK_SYSTEM enabled.
Regards,
Colin Chargy

@tomy2105
Copy link
Contributor Author

I agree with you completely, as noted in my comment of #95, that it would be better not to use boost autolink for non-boost libraries.
Did not want to go down that path myself, but left that to original developers, because I wasn't sure what was the initial reason to use boost autolinking on non-boost libraries.

However, I'd suggest you open new issue since this one is closed.

In addition please note that, although source of the problem is the same, the problem itself would be different (prior to my fix) when using BOOST_AUTO_LINK_NOMANGLE compared to using BOOST_AUTO_LINK_TAGGED or BOOST_AUTO_LINK_SYSTEM.

If BOOST_AUTO_LINK_NOMANGLE was defined, it would become undefined and all subsequent linking of boost libraries would start behaving differently (as if BOOST_AUTO_LINK_NOMANGLE was not defined).

On the other hand if BOOST_AUTO_LINK_TAGGED or BOOST_AUTO_LINK_SYSTEM, linking of external libraries in uuid would fail but other boost libs would not be affected.

Hence, due to difference in problem manifestation, BOOST_AUTO_LINK_TAGGED or BOOST_AUTO_LINK_SYSTEM, probably deserve separate issue :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants