Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes https://github.com/boostorg/uuid/issues/94 #95

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

tomy2105
Copy link
Contributor

@tomy2105 tomy2105 commented Mar 28, 2019

Avoid undefining BOOST_AUTO_LINK_NOMANGLE if it was previously defined.

Maybe better solution would be to directly
#pragma comment(lib, "bcrypt.lib")
#pragma comment(lib, "advapi32.lib")
or
#pragma comment(lib, "coredll.lib")

Since <boost/config/auto_link.hpp> seems to be oriented for various logics for linking boost libs and those 3 are not boost libs.

Didn't want to go to change that big myself, so implemented one that still uses auto_link.hpp but solves the problem.

This fixes #94

Avoid undefining BOOST_AUTO_LINK_NOMANGLE if it was previously defined.
@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #95 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #95   +/-   ##
========================================
  Coverage    80.09%   80.09%           
========================================
  Files           13       13           
  Lines          638      638           
  Branches       152      152           
========================================
  Hits           511      511           
  Misses          17       17           
  Partials       110      110

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2400f69...c07c1fd. Read the comment docs.

@jeking3 jeking3 added the bug label Apr 19, 2019
@jeking3 jeking3 merged commit 32469a6 into boostorg:develop Apr 19, 2019
@ColinChargyBentley
Copy link

Hi,
In fact, the same kind of behavior can happen with BOOST_AUTO_LINK_TAGGED or BOOST_AUTO_LINK_SYSTEM enabled. For example, with BOOST_AUTO_LINK_TAGGED enabled, the linking is failing with this error :
LINK : fatal error LNK1104: cannot open file 'libbcrypt-mt-x64.lib'

I think that would be a good idea to avoid using auto_link for non-boost libs.
Regards,
Colin Chargy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid undefining BOOST_AUTO_LINK_NOMANGLE if it was previously defined.
3 participants