-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include code-quality checks #47
Comments
Hey @lopezator, thanks for offering to work on this. I think this is an excellent idea and certainly look forward to your contribution. Do we need to use a makefile? Would running the checks using a shell script suffice? |
Sure. However IMHO Makefiles gives you better flexibility as you can organize better the different checks and run individual targets easily. |
That makes sense. Let's go with makefiles then. |
Merged in #49 |
Including code-quality checks should be a must for every go project.
We tend to use in our projects the following ones: goimports, golint, vet, megacheck, errcheck.
They han proven to be very useful.
Possibly add more?
I was thinking of adding a Makefile, refactor the code to pass all the checks, and possibly integrate that Makefile check as a Travis CI building stage?
I would take over this.
Thoughts?
The text was updated successfully, but these errors were encountered: