Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include code-quality checks #47

Closed
lopezator opened this issue Nov 9, 2018 · 4 comments
Closed

Include code-quality checks #47

lopezator opened this issue Nov 9, 2018 · 4 comments

Comments

@lopezator
Copy link
Contributor

Including code-quality checks should be a must for every go project.

We tend to use in our projects the following ones: goimports, golint, vet, megacheck, errcheck.

They han proven to be very useful.

Possibly add more?

I was thinking of adding a Makefile, refactor the code to pass all the checks, and possibly integrate that Makefile check as a Travis CI building stage?

I would take over this.

Thoughts?

@F21
Copy link
Member

F21 commented Nov 9, 2018

Hey @lopezator, thanks for offering to work on this. I think this is an excellent idea and certainly look forward to your contribution.

Do we need to use a makefile? Would running the checks using a shell script suffice?

@lopezator
Copy link
Contributor Author

Sure.

However IMHO Makefiles gives you better flexibility as you can organize better the different checks and run individual targets easily.

@F21
Copy link
Member

F21 commented Nov 9, 2018

That makes sense. Let's go with makefiles then.

@F21
Copy link
Member

F21 commented Jan 11, 2019

Merged in #49

@F21 F21 closed this as completed Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants