Skip to content

Conversation

ledo01
Copy link

@ledo01 ledo01 commented Jun 17, 2024

This scanner can emit license finding. As such, it should be marked as a license scanner and have the rule for forbidden license usage.

Resolves: BST-11165, BST-11167

This scanner can emit license finding. As such, it should be marked as a
license scanner and have the rule for forbidden license usage.
@ledo01 ledo01 requested a review from a team June 17, 2024 14:35
lindycoder
lindycoder previously approved these changes Jun 17, 2024
Copy link

@lindycoder lindycoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, wrong scanner

@lindycoder lindycoder dismissed their stale review June 17, 2024 20:32

It was not a good review

- boostsecurityio/oss-license

rules:
dependency-with-malicious-behaviour:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this should be only 1 place as well

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, can be cleaned up in a later PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ledo01 ledo01 merged commit 8012616 into main Jun 17, 2024
@ledo01 ledo01 deleted the bst-11165-boost-sca-license branch June 17, 2024 20:55
fproulx-boostsecurity pushed a commit that referenced this pull request Jul 12, 2024
* BST-11165: add license type & rule to boost-sca (#132)

* BST-11165: add license type & rule to boost-sca (#132) (#133)

* [BST-11135] Upgrade converter for OSV scanner (#134)

---------

Co-authored-by: Victor Barroncas <59754066+victor-nb@users.noreply.github.com>
fproulx-boostsecurity added a commit that referenced this pull request Aug 5, 2024
Signed-off-by: François Proulx <76956526+fproulx-boostsecurity@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants