Skip to content

Commit 1dc87a1

Browse files
committed
Tweaks for modal header
1 parent 975a2b0 commit 1dc87a1

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

bootbox.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
dialog: '<div class="bootbox modal" tabindex="-1" role="dialog" aria-hidden="true"><div class="modal-dialog"><div class="modal-content"><div class="modal-body"><div class="bootbox-body"></div></div></div></div></div>',
8181
header: '<div class="modal-header"><h5 class="modal-title"></h5></div>',
8282
footer: '<div class="modal-footer"></div>',
83-
closeButton: '<button type="button" class="bootbox-close-button close btn-close" aria-hidden="true"></button>',
83+
closeButton: '<button type="button" class="bootbox-close-button close btn-close" aria-hidden="true" aria-label="Close"></button>',
8484
form: '<form class="bootbox-form"></form>',
8585
button: '<button type="button" class="btn"></button>',
8686
option: '<option value=""></option>',
@@ -379,11 +379,15 @@
379379
closeButton.html('&times;');
380380
}
381381

382-
if (options.bootstrap > 3) {
383-
dialog.find('.modal-header').append(closeButton);
384-
}
385-
else {
386-
dialog.find('.modal-header').prepend(closeButton);
382+
/* Note: the close button for Bootstrap 5+ does not contain content */
383+
if(options.bootstrap < 5){
384+
if (options.bootstrap == 4) {
385+
dialog.find('.modal-header').append(closeButton);
386+
}
387+
else {
388+
/* Bootstrap 3 and under */
389+
dialog.find('.modal-header').prepend(closeButton);
390+
}
387391
}
388392
}
389393
}

0 commit comments

Comments
 (0)