lints: Various improvements #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrothberg
approved these changes
Jan 17, 2025
Internal only change, but prep for future work; I want to track the version lints were introduced in, support clearly differentiating between warnings and fatal errors, etc. Specifically motivated by custom base image work coreos/rpm-ostree#5221 but also obviously useful in general. Signed-off-by: Colin Walters <walters@verbum.org>
Everything right now is fatal, but this is prep for adding non-fatal warnings (actually more like the original motivation of lints). Signed-off-by: Colin Walters <walters@verbum.org>
Add an internal error type, and switch to using a nested `Result<Result<>>` approach for lints. This allows cleanly distinguishing between e.g. "we failed to open a file" from "the lint correctly/successfully found something wrong". This is also helpful for being able to skip lint failures - we wouldn't want to silently skip runtime failures. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
lints-minor
branch
from
2904a90 to
8dd04af
Compare
cgwalters
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal only change, but prep for future work; I want to track the version lints were introduced in, support clearly differentiating between warnings and fatal errors, etc.
Specifically motivated by custom base image work
coreos/rpm-ostree#5221
but also obviously useful in general.