install/blockdev: Break cyclic build dependency #1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The install code and the blockdev code call each other. Clean up blockdev to only use `bootc-utils`. Prep for splitting out the blockdev stuff into at least a separate internal crate; ref coreos/bootupd#820 Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
blockdev-no-task
branch
from
d19ff97 to
b23777f
Compare
HuijingHei
approved these changes
Jan 21, 2025
It will be in the future when splitting this into a separate crate yes. At the moment those suppress some unused variable warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The install code and the blockdev code call each other. Clean up blockdev to only use
bootc-utils.Prep for splitting out the blockdev stuff into at least a separate internal crate; ref
coreos/bootupd#820