tests: Verify we emit journal messages

[cgwalters]

Followup to previous commit.

[gemini-code-assist]

Code Review

This pull request adds a test to verify that a journal message is emitted when bootc switch is run, which is a good addition for ensuring logging behavior. My feedback focuses on improving the maintainability of the test by avoiding a magic string for the message ID.

[gemini-code-assist]

Code Review

This pull request adds a test to verify that a journal message is emitted during a bootc switch operation. However, the test is checking for the message ID of an in-place switch, while the test itself performs a standard switch. My review corrects this ID and suggests a more explicit way to verify the journal entry exists, improving the test's correctness and robustness.

[gemini-code-assist]

The message ID being checked appears to be incorrect for this test case. The bootc switch command executed on line 63 does not include the --mutate-in-place flag, so it performs a standard switch operation. The journal message for a standard switch has the ID 7a6b5c4d3e2f1a0b9c8d7e6f5a4b3c2d1, not 3e2f1a0b9c8d7e6f5a4b3c2d1e0f9a8b7 which is for an in-place switch.

Additionally, the check is implicit, relying on the exit code of journalctl. It would be more robust and explicit to check that at least one log entry is found, for example by explicitly checking the exit code of the command.

let result = do --ignore-errors { journalctl --quiet _MESSAGE_ID=7a6b5c4d3e2f1a0b9c8d7e6f5a4b3c2d1 }
assert $result.exit_code == 0

[cgwalters]

Oh wow, well spotted gemini except...actually the problem is switch in place and switch have the same message ID, which was probably (?) not intentional.

[gursewak1997]

so do we change the ID then?

[cgwalters]

Yeah I think we should change one of them, but I would say it should be a separate PR?