Skip to content

Conversation

cgwalters
Copy link
Collaborator

No description provided.

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a documentation section to bootc-status.8.md to explain how to differentiate between a bootc-managed and an rpm-ostree-managed system. The explanation is valuable. My feedback focuses on improving the clarity and readability of the new text to make it even more helpful for users.

@cgwalters cgwalters enabled auto-merge (rebase) September 24, 2025 16:36
Copy link
Contributor

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sane to me!

and tools like rpm-ostree end up sharing the same code and doing effectively the same thing.
Hence, there isn't a mechanism to detect if a system "is bootc" or "is rpm-ostree".

However, if the `incompatible` flag is set on a deployment, then there are layered packages and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
However, if the `incompatible` flag is set on a deployment, then there are layered packages and
However, if the `incompatible` flag is set on a deployment in the `bootc status --json` output, then there are layered packages and

Copy link

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlebon
Copy link
Contributor

jlebon commented Sep 26, 2025

Opened coreos/zincati#1316 related to this.

@SNThrailkill
Copy link

Thanks for adding this, I was just looking for this. LGTM

@cgwalters cgwalters disabled auto-merge October 7, 2025 22:20
@cgwalters cgwalters merged commit a13ba6d into bootc-dev:main Oct 7, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants