Skip to content

Conversation

cgwalters
Copy link
Collaborator

  • Having separate workflows made sharing build artifacts not really possible, and it just makes sense to consolidate
  • Refactor shared parts into a little internal action

@bootc-bot bootc-bot bot requested a review from jeckersb September 24, 2025 15:02
@cgwalters cgwalters requested a review from henrywang September 24, 2025 15:08
@cgwalters cgwalters force-pushed the build-sys-even-more2 branch 2 times, most recently from fe009f7 to f3ce17d Compare September 24, 2025 16:47
@cgwalters cgwalters marked this pull request as ready for review September 24, 2025 17:59
@cgwalters cgwalters enabled auto-merge (rebase) September 24, 2025 18:30
@cgwalters
Copy link
Collaborator Author

To merge this we'll need to force it to override the expected CI contexts.

- Having separate workflows made sharing build artifacts not
  really possible, and it just makes sense to consolidate
- Refactor shared parts into a little internal action

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cgwalters, Do we still need to run all those test when push to main?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not? I am not aware of anyone monitoring the actions that run post-merge (though of course we could start doing so).

What it would catch is semantic merge conflicts, but the more I think about it the more I feel we should go to merge queues.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can move integration test into merge_queue trigger and keep the rest test in pull_request trigger?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think that should block this one?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need to run same test twice (pull_request and merge_queue).
We can land this PR first and make changes when we enable merge_queue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK can you approve the PR please?

@cgwalters cgwalters merged commit 9a6df09 into bootc-dev:main Sep 26, 2025
26 of 27 checks passed
@cgwalters
Copy link
Collaborator Author

I've adjusted the required CI context names to match this PR.

@cgwalters
Copy link
Collaborator Author

Note: This means all outstanding PRs will need to be rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants