-
Notifications
You must be signed in to change notification settings - Fork 141
ci: Consolidate and cleanup workflows #1646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cgwalters
commented
Sep 24, 2025
- Having separate workflows made sharing build artifacts not really possible, and it just makes sense to consolidate
- Refactor shared parts into a little internal action
fe009f7
to
f3ce17d
Compare
To merge this we'll need to force it to override the expected CI contexts. |
- Having separate workflows made sharing build artifacts not really possible, and it just makes sense to consolidate - Refactor shared parts into a little internal action Signed-off-by: Colin Walters <walters@verbum.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cgwalters, Do we still need to run all those test when push
to main
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not? I am not aware of anyone monitoring the actions that run post-merge (though of course we could start doing so).
What it would catch is semantic merge conflicts, but the more I think about it the more I feel we should go to merge queues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we can move integration test into merge_queue
trigger and keep the rest test in pull_request
trigger?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think that should block this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need to run same test twice (pull_request
and merge_queue
).
We can land this PR first and make changes when we enable merge_queue
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK can you approve the PR please?
f3ce17d
to
47c2bd1
Compare
I've adjusted the required CI context names to match this PR. |
Note: This means all outstanding PRs will need to be rebased |