Skip to content

Conversation

jeckersb
Copy link
Collaborator

@jeckersb jeckersb commented Oct 7, 2025

Signed-off-by: John Eckersberg jeckersb@redhat.com

@bootc-bot bootc-bot bot requested a review from henrywang October 7, 2025 20:55
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a workaround for a Podman bug related to handling secrets in remote builds by updating the .dockerignore file. The change ensures that temporary secret files are included in the build context. My review includes a suggestion to make the ignore pattern more specific to improve precision and prevent unintentionally including other files.

@jeckersb
Copy link
Collaborator Author

jeckersb commented Oct 7, 2025

Ok now why are docs failing because it can't find perl... death by a thousand paper cuts today 😭

Signed-off-by: John Eckersberg <jeckersb@redhat.com>
@jeckersb jeckersb force-pushed the dockerignore-secrets branch from d6c7b8b to bc20360 Compare October 7, 2025 21:17
@cgwalters
Copy link
Collaborator

Ok now why are docs failing because it can't find perl...

I see:

INFO has_release_artifact{release=GhRelease { repo: GhRepo { owner: "Michael-F-Bryan", repo: "mdbook-linkcheck" }, tag: "0.7.7" } artifact_name="mdbook-linkcheck-x86_64-unknown-linux-gnu-v0.7.7.tbz2"}:do_send_request{request=Request { method: GET, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("api.github.com")), port: None, path: "/repos/Michael-F-Bryan/mdbook-linkcheck/releases/tags/0.7.7", query: None, fragment: None }, headers: {"accept": "application/vnd.github+json", "x-github-api-version": "2022-11-28"} } url=https://api.github.com/repos/Michael-F-Bryan/mdbook-linkcheck/releases/tags/0.7.7}: Received status code 403 Forbidden, will wait for 120s and retry

We're getting a 403 querying the releases (ratelimit?).

That causes cargo-binstall to fall back to building from source, and yeah openssl+perl.

@jeckersb
Copy link
Collaborator Author

jeckersb commented Oct 7, 2025

Ok now why are docs failing because it can't find perl...

I see:

INFO has_release_artifact{release=GhRelease { repo: GhRepo { owner: "Michael-F-Bryan", repo: "mdbook-linkcheck" }, tag: "0.7.7" } artifact_name="mdbook-linkcheck-x86_64-unknown-linux-gnu-v0.7.7.tbz2"}:do_send_request{request=Request { method: GET, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("api.github.com")), port: None, path: "/repos/Michael-F-Bryan/mdbook-linkcheck/releases/tags/0.7.7", query: None, fragment: None }, headers: {"accept": "application/vnd.github+json", "x-github-api-version": "2022-11-28"} } url=https://api.github.com/repos/Michael-F-Bryan/mdbook-linkcheck/releases/tags/0.7.7}: Received status code 403 Forbidden, will wait for 120s and retry

We're getting a 403 querying the releases (ratelimit?).

That causes cargo-binstall to fall back to building from source, and yeah openssl+perl.

Ahhh good catch 👍

@cgwalters cgwalters enabled auto-merge (rebase) October 7, 2025 21:57
@cgwalters cgwalters disabled auto-merge October 7, 2025 21:57
@cgwalters cgwalters enabled auto-merge (rebase) October 7, 2025 22:19
@cgwalters cgwalters merged commit 93f4360 into bootc-dev:main Oct 7, 2025
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants