Add suggestion for LABEL containers.bootc 1
#299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
bootc-label
branch
from
8244d76 to
fae644c
Compare
cgwalters
added a commit
to cgwalters/centos-bootc
that referenced
this pull request
Feb 5, 2024
Pairs with bootc-dev/bootc#299 This is intended to be the new canonical label for bootc-compatible images, as opposed to the existing `ostree.linux` etc.
As we aim to slowly move away from ostree, let's add a bootc label that we expect to be used. For now, this is just a warning. I will change rpm-ostree to add this by default if we take this. But this one is also an important step for if we ever add the flow of simply deriving from an existing application base image. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
bootc-label
branch
from
fae644c to
b766db8
Compare
|
OK we learned from #297 that our usage of In the general case we're probably going to need to grow a logging abstraction a bit like what rpm-ostree has where we can write to a mix of stdout (when running as a systemd unit directly e.g. as part of |
cgwalters
added a commit
to cgwalters/ostree-rs-ext
that referenced
this pull request
Feb 5, 2024
See bootc-dev/bootc#299 Since we want to move ostree more into the background, this new label name puts the focus on bootc.
|
Also did ostreedev/ostree-rs-ext#595 related to this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we aim to slowly move away from ostree, let's add a bootc label that we expect to be used. For now, this is just a warning.
I will change rpm-ostree to add this by default if we take this.
But this one is also an important step for if we ever add the flow of simply deriving from an existing application base image.