Skip to content

Conversation

cgwalters
Copy link
Collaborator

I went through the docs and cleaned some things up, fixed some missing content, etc.

Also a patch to xtask to make it so that cargo xtask manpages works even when $PWD is in docs.

@jeckersb jeckersb self-requested a review March 29, 2024 15:27
Copy link
Collaborator

@jeckersb jeckersb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, just noted a couple of minor things

@jeckersb jeckersb enabled auto-merge March 29, 2024 18:08
I went through the docs and cleaned some things up, fixed
some missing content, etc.

Also a patch to `xtask` to make it so that `cargo xtask manpages`
works even when $PWD is in `docs`.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters
Copy link
Collaborator Author

OK the git rev-parse failure is weird; took a stab at both propagating stderr to aid debugging, and I'm guessing it's the git "safe directory" stuff so I cargo culted a bit for that.

@cgwalters
Copy link
Collaborator Author

Ah yes, my intuition about the safe directory bits was right 😄

@cgwalters cgwalters disabled auto-merge March 29, 2024 18:39
@cgwalters cgwalters merged commit a4cf3ff into bootc-dev:main Mar 29, 2024
@cgwalters
Copy link
Collaborator Author

(force merging since we had green CI before)

cgwalters pushed a commit to cgwalters/bootc that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants